<html>
<head><meta charset="utf-8"><title>macOS src component failing on nightly · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html">macOS src component failing on nightly</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="204674913"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204674913" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> XAMPPRocky <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204674913">(Jul 22 2020 at 14:42)</a>:</h4>
<p>Installing the rust src component is currently consistently failing for me on nightly. Not sure where is the best place for this.<br>
<a href="https://github.com/XAMPPRocky/tokei/pull/592/checks?check_run_id=897514803">https://github.com/XAMPPRocky/tokei/pull/592/checks?check_run_id=897514803</a></p>
<div class="codehilite"><pre><span></span><code>info: syncing channel updates for &#39;nightly-x86_64-apple-darwin&#39;
info: latest update on 2020-07-22, rust version 1.47.0-nightly (8ad7bc3f4 2020-07-21)
info: downloading component &#39;cargo&#39;
info: downloading component &#39;rust-std&#39;
info: downloading component &#39;rustc&#39;
info: installing component &#39;cargo&#39;
info: Defaulting to 500.0 MiB unpack ram
info: installing component &#39;rust-std&#39;
info: installing component &#39;rustc&#39;
info: default toolchain set to &#39;nightly-x86_64-apple-darwin&#39;

  nightly-x86_64-apple-darwin installed - rustc 1.47.0-nightly (8ad7bc3f4 2020-07-21)

info: downloading component &#39;rust-std&#39; for &#39;aarch64-apple-ios&#39;
info: installing component &#39;rust-std&#39; for &#39;aarch64-apple-ios&#39;
info: Defaulting to 500.0 MiB unpack ram
info: downloading component &#39;rust-src&#39;
info: installing component &#39;rust-src&#39;
info: Defaulting to 500.0 MiB unpack ram
info: rolling back changes
error: tar entry kind &#39;Symlink&#39; is not supported
error: couldn&#39;t install the `rust-src` component
caused by: `&quot;rustup&quot; &quot;component&quot; &quot;add&quot; &quot;rust-src&quot; &quot;--toolchain&quot; &quot;nightly-x86_64-apple-darwin&quot;` failed with exit code: Some(1)
</code></pre></div>



<a name="204675073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675073">(Jul 22 2020 at 14:43)</a>:</h4>
<p>known bug</p>



<a name="204675099"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675099" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675099">(Jul 22 2020 at 14:44)</a>:</h4>
<p>should be fixed next nightly</p>



<a name="204675152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675152">(Jul 22 2020 at 14:44)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/74578">https://github.com/rust-lang/rust/pull/74578</a></p>



<a name="204675397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675397">(Jul 22 2020 at 14:46)</a>:</h4>
<p>I'm starting to wonder if rustup should just make that a warning and skip the entry rather than fail the install.  We added that check for security reasons because there should never be symlinks in the tarballs as they can't be represented on all host platforms.</p>



<a name="204675457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675457">(Jul 22 2020 at 14:46)</a>:</h4>
<p>For similar reasons we ban device nodes.</p>



<a name="204675469"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675469" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675469">(Jul 22 2020 at 14:46)</a>:</h4>
<p>Why can't the tarballs resolve the symlinks?</p>



<a name="204675750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675750">(Jul 22 2020 at 14:48)</a>:</h4>
<p>Well, I suppose we could write a symlink resolution tool and then make a copy on the filesystem but that seems a bit risky to me.  Better to ban them outright.  We could add a check to the tarball build process in r-l/r if we wanted to make sure this can't happen again.</p>



<a name="204675806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675806">(Jul 22 2020 at 14:49)</a>:</h4>
<p>yeah we should ban earlier that's all</p>



<a name="204675866"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675866" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675866">(Jul 22 2020 at 14:49)</a>:</h4>
<p>I think verifying that the generated tarballs don't have bad things in should be a step we do in CI of r-l/r</p>



<a name="204675974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675974">(Jul 22 2020 at 14:50)</a>:</h4>
<p>To be clear, I mean</p>
<div class="codehilite"><pre><span></span><code>-h, --dereference
    don&#39;t archive symlinks; archive the files they point to
</code></pre></div>



<a name="204675979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204675979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204675979">(Jul 22 2020 at 14:50)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> yeah that's what I meant</p>



<a name="204676007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204676007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jake Goulding <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204676007">(Jul 22 2020 at 14:50)</a>:</h4>
<p>you'd still have the checks that the tarball doesn't have symlinks</p>



<a name="204676019"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204676019" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204676019">(Jul 22 2020 at 14:50)</a>:</h4>
<p>DItto it'd be nice if we could notice getting close to the unpack sanity limit in rustup. (individual files may not exceed a built-in sanity limit size or rustup refuses to unpack it)</p>



<a name="204676120"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204676120" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Daniel Silverstone <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204676120">(Jul 22 2020 at 14:51)</a>:</h4>
<p>(for reference, right now, that limit is 200_000_000 bytes)</p>



<a name="204682621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/macOS%20src%20component%20failing%20on%20nightly/near/204682621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eric Huss <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/macOS.20src.20component.20failing.20on.20nightly.html#204682621">(Jul 22 2020 at 15:37)</a>:</h4>
<p>When I get a chance, I plan to add a check somewhere that there aren't any symlinks.  If there is ever a situation in the future where there is a symlink that is needed, we can add the equivalent of <code>dereference</code>, but I think that should be done carefully since that might not be what is expected, and may cause subtle problems, or cause substantial duplication.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>